Conversation
niole
commented
Feb 20, 2026
| ("parent2", {'x':1}, 1), ("unit_1", {'x':1}, 1), ("unit_2", {'x':2}, 2) | ||
| ], key=lambda x: x[0]) | ||
|
|
||
| expected_spans = [("parent", {'x':1, 'y': 2}, 3), \ |
Contributor
Author
There was a problem hiding this comment.
The change is that sibling spans with the same name no longer get _n suffixes, e.g unit_1 is now just unit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA
DOM-XYZ
What issue does this pull request solve?
placeholder
What is the solution?
placeholder
Testing
Briefly describe how the change was tested. The purpose of this section is that a reviewer can identify a test gap, if any.
e.g. "I ran an upgrade from 4.2 to 4.6".
Pull Request Reminders
References (optional)